Automatically pass through all on* event attributes #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed NPE which surfaced during HeadRendererTest jakartaee/faces#1507
which are not known as hardcoded component attributes jakartaee/faces#1507
components; reverted temp changes to AjaxHandler/UIComponentBase jakartaee/faces#1507
jakartaee/faces#1507 -- we still need to bump Java version of Faces 5.0 project to align with Jakarta EE 11
…h_all_on-event_attributes
…h_all_on-event_attributes
rest where possible
…tomatically_pass_through_all_on-event_attributes
…h_all_on-event_attributes
|
looks good for me @volosied @melloware can you also give a look plz? |
melloware
suggested changes
Oct 30, 2023
impl/src/main/java/jakarta/faces/component/html/HtmlEvents.java
Outdated
Show resolved
Hide resolved
|
I like it. This is a big change but it will be a good one for 5.0. I will have to study the MyFaces code on exactly where to put this stuff. |
…h_all_on-event_attributes
faces_issue_1507_automatically_pass_through_all_on-event_attributes
|
Sorry, didn't see the notifications until now. I'll take a look at this tomorrow or Tuesday! |
faces_issue_1507_automatically_pass_through_all_on-event_attributes
|
API part of original PR is split into jakartaee/faces#1880 |
faces_issue_1507_automatically_pass_through_all_on-event_attributes
…tomatically_pass_through_all_on-event_attributes
…h_all_on-event_attributes
mnriem
approved these changes
Sep 4, 2024
BalusC
deleted the
faces_issue_1507_automatically_pass_through_all_on-event_attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jakartaee/faces#1507
With this PR, the following finally works for any on* event attribute and f:ajax event="..." without need to register event name as a new attribute in component as long as the event name is covered by ClientBehaviorHolder#getEventNames():
Done so far:
jakarta.faces.component.html.HtmlEventshelper class for managing all these attributesClientBehaviorHolder#getEventNames()to catch up current standard (without the need to add new attribute getter/setter pairs!)jakarta.faces.ADDITIONAL_HTML_EVENT_NAMES, defined in newjakarta.faces.component.html.HtmlEventsclass